Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix secure-random to ignore random.SystemRandom #230

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

drdavella
Copy link
Member

@drdavella drdavella commented Jan 30, 2024

Overview

Using random.SystemRandom is secure and should not be replaced

Details

  • I'm probably going to backport this as another bugfix release

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (40a66c8) 96.60% compared to head (fb4364c) 96.60%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #230   +/-   ##
=======================================
  Coverage   96.60%   96.60%           
=======================================
  Files         101      101           
  Lines        4275     4275           
=======================================
  Hits         4130     4130           
  Misses        145      145           
Files Coverage Δ
src/core_codemods/secure_random.py 100.00% <ø> (ø)

@drdavella drdavella added this pull request to the merge queue Jan 31, 2024
Merged via the queue into main with commit e33e8ea Jan 31, 2024
15 checks passed
@drdavella drdavella deleted the fix-secure-random branch January 31, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants